Repository navigation
fix(profile): end a barless profile's scroll at Leave Chat - #1037
Merged
Merged
Conversation
Opened from the chat, a group profile long enough to scroll left about 80pt of empty space under Leave Chat: the pinned bar's 56pt clearance stayed on with no bar to clear, under the content's own 24pt padding. A profile without a pinned bar now takes no clearance. Leave Chat ending the scroll sits where the pinned bar puts it, overlapping the home indicator's inset by 12pt, and the barless fade covers only that inset so it no longer dims the button. The DM profile's encryption line gets the same clearance and fade. ProfileScrollFit no longer offsets for a clearance that turned on with overflow, since none does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened from the chat, a group profile long enough to scroll left about 80pt of empty space under Leave Chat. The pinned bar's 56pt clearance stayed on with no bar to clear, under the content's own 24pt padding.
ProfileScrollFitdrops its offset for a clearance that turned on with overflow, since none does now.